Skip to content

[fix] Lookup add condition after model is set#1558

Merged
DarkSide666 merged 1 commit intodevelopfrom
fix/1556-lookup-add-condition
Dec 4, 2020
Merged

[fix] Lookup add condition after model is set#1558
DarkSide666 merged 1 commit intodevelopfrom
fix/1556-lookup-add-condition

Conversation

@ibelar
Copy link
Contributor

@ibelar ibelar commented Dec 4, 2020

replacement for PR #1556

@mvorisek
Copy link
Member

mvorisek commented Dec 4, 2020

I think our code should not lead to these fixes, but ok for now

@DarkSide666 DarkSide666 self-requested a review December 4, 2020 17:39
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 16c6efb into develop Dec 4, 2020
@DarkSide666 DarkSide666 deleted the fix/1556-lookup-add-condition branch December 4, 2020 17:39
@mhuser
Copy link
Contributor

mhuser commented Dec 5, 2020

Great, thank you so much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants