Skip to content

MNT: Numpy 2.1 compatibility for HDF5 table reader#16814

Merged
pllim merged 2 commits into
astropy:mainfrom
pllim:np-2.1-compat
Aug 12, 2024
Merged

MNT: Numpy 2.1 compatibility for HDF5 table reader#16814
pllim merged 2 commits into
astropy:mainfrom
pllim:np-2.1-compat

Conversation

@pllim

@pllim pllim commented Aug 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Numpy 2.1 compatibility for HDF5 table reader. This ignores the warning for now because h5py/h5py#2416 is not released yet but we are picking up numpy 2.1rc in the pre-deps job.

Noticed the failure in daily cron. Example log: https://github.com/astropy/astropy/actions/runs/10345199740/job/28631875521

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v6.1.3 milestone Aug 12, 2024
@github-actions

github-actions Bot commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim marked this pull request as ready for review August 12, 2024 13:29
@pllim

pllim commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

aarch64 is canceled (#16565)

mhvk
mhvk approved these changes Aug 12, 2024
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked!

Comment thread astropy/io/misc/hdf5.py Outdated
@pllim pllim requested a review from neutrinoceros August 12, 2024 14:09
@pllim @neutrinoceros
TST: Temporarily ignore DeprecationWarning from h5py
5a9ec7e 
because its numpy 2.1 compatibility patch has not been released
but numpy 2.1rc is out.

Co-authored-by: Clément Robert <[email protected]>
@pllim pllim added the Upstream Action Required Was: Upstream Fix Required label Aug 12, 2024
mhvk
mhvk approved these changes Aug 12, 2024
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tendency would be to add the Table(np.array(input, copy=True), copy=False), since we might as well ensure there are not two copies while we are at it -- unlikely we'll get back to this soon! But obviously also fine to just go with the fix...

@pllim @mhvk
Avoid double copy when creating table
d92cb01 
from HDF5 data.

Co-authored-by: Marten van Kerkwijk <[email protected]>
@pllim

pllim commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

Re: #16814 (review)

Sure, doesn't hurt. Added you as co-author as well. Thanks, @mhvk !

mhvk
mhvk approved these changes Aug 12, 2024
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks all good to me!

@pllim

pllim commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

link check failure is related. Thanks for the reviews!

@pllim pllim merged commit c02979a into astropy:main Aug 12, 2024
@pllim pllim deleted the np-2.1-compat branch August 12, 2024 16:43
@lumberbot-app

This comment was marked as resolved.

Sign in to view
This was referenced Aug 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner

@matteobachetti matteobachetti Awaiting requested review from matteobachetti matteobachetti is a code owner

@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros is a code owner

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR io.misc no-changelog-entry-needed numpy-dev Upstream Action Required Was: Upstream Fix Required

Projects

None yet

Milestone

v6.1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @mhvk @neutrinoceros