Skip to content

TST: add a test job for numpy 2.0.0 pre-releases#16249

Closed
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/regular_testing_with_numpy2_0_0_prerel
Closed

TST: add a test job for numpy 2.0.0 pre-releases#16249
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/regular_testing_with_numpy2_0_0_prerel

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Numpy 2.0.0rc1 is now imminent (according to numpy/numpy#24300 (comment))
As I noted in #16229, we're not currently testing against numpy 2.0.0 pre-releases, and testing against the dev branch has proven to be an insufficient proxy, so I propose we introduce a new (temporary) test job specifically focused on covering this case.
I've tested this branch on my fork and pinning numpy to version 2.0.0b1, but this may become outdated very soon, so I'll keep this as a draft until one of the following happens:

  • numpy 2.0.0rc1 is out and I can update this PR
  • the week-end is over

Maintainers should feel free to push to this branch if there's a need for getting this in earlier.
I don't think I'll be actively working on this over the weekend, but I'll still happily respond to pings, so please do ping me if you need to update this so I know to be careful if I want to push again myself.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v6.1.0 milestone Mar 29, 2024

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is necessary. We already test against pre-releases daily at

toxenv: py312-test-alldeps-predeps
. We can also run it as needed via workflow dispatch. If you want to run that job in PR, you can use "Extra CI" label.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Oh, I wasn't aware we did this, thanks for pointing it out !
I note however that daily cron jobs are not picking up numpy 2.0.0b1 at the moment (someone else from the stack of dependencies we're grabbing must be pinning it ?), so right now it might still have some value to add a job just for numpy 2.0. That being said, I should also note that, when I opened this PR yesterday, I thought I was seeing another regression when testing locally against numpy maintenance/2.0.x, but it turned out to be a different problem which had nothing to do with numpy, so there's also less of a need for this job than I previously thought.

Anyway, I propose we re-assess on what to do with this PR on Monday, and maybe by then we'll even see an actual release candidate ?

@astrofrog

Copy link
Copy Markdown
Member

We could also just add this to the integration testing repo?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Sure ! where's that ?

@pllim

pllim commented Apr 1, 2024

Copy link
Copy Markdown
Member

Ah, right. It is at https://github.com/astropy/astropy-integration-testing

I kicked off https://github.com/astropy/astropy-integration-testing/actions/runs/8512968778/job/23315688712 but since we pinned numpy<2 for astropy v6.0.1 and we do not yet have astropy v6.1rc, it is not picking up numpy 2.0rc. FYI.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

since we pinned numpy<2 for astropy v6.0.1 and we do not yet have astropy v6.1rc, it is not picking up numpy 2.0rc.

2.0.0rc1 actually still matches <2, but as I said in #16249 (comment), something else in the env must be pinning it harder (possibly scipy). Anyway, it looks like we're already doing everything we can on our side and there don't seem to be actual hidden incompatibilities to catch any more so let's just close this for now. Thank you both !

@neutrinoceros neutrinoceros deleted the numpy2/regular_testing_with_numpy2_0_0_prerel branch April 2, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants