BUG: fix compatibility with numpy@maintenance/v2.0.x#16229
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
Note that I do not recommend we add a test job for the backport branch, as the release candidate is expected any day now and would be easier to test against. I also assume that this kind of failures should be rare enough that it's not worth checking for them systematically. However, running the test suite locally will be part of my morning routine until we see numpy 2.0.0rc1 😄 |
|
Looks like this went under everyone's radar yesterday. @mhvk can you review this please ? |
mhvk
left a comment
There was a problem hiding this comment.
This looks good!
Would it be possible, in a separate PR, to add numpy 2.0 to our workflows?
I'm planning to do it when rc1 gets out. Possibly earlier if it takes more than a couple days from now. |
Sounds good! |
Description
Since NumPy 2.0.x was branched out, we haven't been testing it directly: devdeps now run against nightlies produced from the 2.1dev (main) branch.
As a result, NumPy 2.0.x is now in a CI blindspot, so I ran tests locally against the backport branch and found this incompatibility.
follow up to #16205
xref numpy/numpy#26033 and its backport numpy/numpy#26052