Skip to content

BUG: declare private str ufuncs as unsupported (np._core.umath._(ljust, rjust, _center, _zfill))#16205

Merged
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/new_str_ufuncs_2
Mar 16, 2024
Merged

BUG: declare private str ufuncs as unsupported (np._core.umath._(ljust, rjust, _center, _zfill))#16205
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:numpy2/new_str_ufuncs_2

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #16144
xref numpy/numpy#25908

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions github-actions Bot added the units label Mar 16, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mhvk

mhvk commented Mar 16, 2024

Copy link
Copy Markdown
Contributor

I did the backport even though perhaps it is not going to be needed - but it should be an easy one anyway.

@mhvk mhvk merged commit f52a09b into astropy:main Mar 16, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 16, 2024
…rted (np._core.umath._(ljust, rjust, _center, _zfill))
@neutrinoceros neutrinoceros deleted the numpy2/new_str_ufuncs_2 branch March 16, 2024 14:14
mhvk added a commit that referenced this pull request Mar 16, 2024
…205-on-v6.0.x

Backport PR #16205 on branch v6.0.x (BUG: declare private str ufuncs as unsupported (np._core.umath._(ljust, rjust, _center, _zfill)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants