Skip to content

BUG/API: Changed the default value of the copy argument in CylindricalDifferential.__init__ from False to True#16198

Merged
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:coordinates/bug/api/CylindricalDifferential_copy_by_default
Mar 14, 2024
Merged

BUG/API: Changed the default value of the copy argument in CylindricalDifferential.__init__ from False to True#16198
mhvk merged 1 commit into
astropy:mainfrom
neutrinoceros:coordinates/bug/api/CylindricalDifferential_copy_by_default

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

Description

Following #16181 (comment)

I'm really not sure if the changelog fragment should be under api or bug. In any case I think this should go to 6.1.0, but I'll let @mhvk be the judge !

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the API change aspect is more important in this case, so let's keep it as you have it!

@mhvk mhvk added this to the v6.1.0 milestone Mar 14, 2024
@mhvk mhvk added the API change PRs and issues that change an existing API, possibly requiring a deprecation period label Mar 14, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review March 14, 2024 20:27
@mhvk mhvk enabled auto-merge March 14, 2024 20:28
@neutrinoceros neutrinoceros changed the title BUG/API: Changed the default value of the copy argument in CylindricalDifferential.__init__ from False to True BUG/API: Changed the default value of the copy argument in CylindricalDifferential.__init__ from False to True Mar 14, 2024
@mhvk mhvk merged commit 92a96e1 into astropy:main Mar 14, 2024
@neutrinoceros neutrinoceros deleted the coordinates/bug/api/CylindricalDifferential_copy_by_default branch March 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period coordinates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants