Conversation
Contributor
Author
|
@amitwer here is PR to completely reorganize the main assertion class into a bunch of sub-classes via the mixin pattern. Feedback? |
Contributor
Author
dwyatte
reviewed
Oct 22, 2019
| self._fmt_args_kwargs(*some_args, **some_kwargs))) | ||
|
|
||
| ### helpers ### | ||
| def _err(self, msg): |
Contributor
There was a problem hiding this comment.
_err is defined here, which uses print, so does assertpy.py need to do from __future__ import print_function opposed to the other files?
Contributor
Author
There was a problem hiding this comment.
correct, but per #97 probably replace print(out) with logger.warning(out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huge refactor of the main
AssertionBuilderclass into separate mixin classes...this should help make things more readable and understandable to others.