Skip to content

fix collections ABC deprecation#90

Merged
saturnboy merged 1 commit intoassertpy:masterfrom
wuan:fix_collection_abc_deprecation
Apr 1, 2019
Merged

fix collections ABC deprecation#90
saturnboy merged 1 commit intoassertpy:masterfrom
wuan:fix_collection_abc_deprecation

Conversation

@wuan
Copy link
Contributor

@wuan wuan commented Mar 10, 2019 •
edited
Loading

This PR removes the use of deprecated ABC collections.Iterable. At least with python 3.7 there is a deprecation message:

 .../assertpy.py:1174: DeprecationWarning: Using or importing the ABCs from 'collections' 
   instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

    if not isinstance(d, collections.Iterable):

@coveralls
Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage increased (+0.0006%) to 99.698% when pulling 49bfed1 on wuan:fix_collection_abc_deprecation into 3958b02 on ActivisionGameScience:master.

@saturnboy saturnboy self-assigned this Apr 1, 2019
@saturnboy saturnboy merged commit 08d799c into assertpy:master Apr 1, 2019
@saturnboy
Copy link
Contributor

saturnboy commented Apr 1, 2019

@wuan thanks for PR, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@saturnboy saturnboy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wuan @coveralls @saturnboy