is_type_of and is_instance_of support for ABC/Metaclass#52
Merged
saturnboy merged 1 commit intoassertpy:masterfrom May 12, 2016
Merged
is_type_of and is_instance_of support for ABC/Metaclass#52saturnboy merged 1 commit intoassertpy:masterfrom
saturnboy merged 1 commit intoassertpy:masterfrom
Conversation
…es and other classes that leverage metaclasses. Existing logic enforced that the passed in type or class reference was actually a type by check "type(arg) is type". This does not allow for using asserting type/instance checks against ABCs, collections.* (lots of ABCs), etc. Added tests for abstract classes.
Contributor
|
@skippyprime awesome! coming from java I use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for type and instance checking for Abstract Base Classes and other class definitions that leverage metaclasses. Existing logic enforced that the passed in type or class reference was actually a type by check "if type(arg) is not type then raise". This does not allow for using asserting type/instance checks against ABCs, collections.* (lots of ABCs), etc. Added tests for abstract classes.
Checks that don't work:
Functions affected:
is_type_ofis_instance_ofTests added:
tests/test_class.py
Defined 3 new classes, with a base implemented as an ABC. Added assertion tests for
is_type_of()andis_instance_of(). All tests pass.