removed broken getVersion and added info to changelog

Almenon · Almenon · commit c63921413c95 · 2018-10-06T11:11:02.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.0.4
+* added getVersionSync
+
 ## 0.0.3
 * fixed buffering in `PythonShell.receive`, fixing [#1](https://github.com/extrabacon/python-shell/issues/1)
 
diff --git a/README.md b/README.md
@@ -275,7 +275,7 @@ Promise is rejected if there is a syntax error.
 Checks the syntax of the file and returns a promise.
 Promise is rejected if there is a syntax error.
 
-#### `version(pythonPath?:string)`
+#### `getVersionSync(pythonPath?:string)`
 
 Returns the python version. Optional pythonPath param to get the version 
 of a specific python interpreter.
diff --git a/index.ts b/index.ts
@@ -213,7 +213,7 @@ export class PythonShell extends EventEmitter{
         }
     };
 
-    /**
+        /**
 	 * checks syntax without executing code
 	 * @param {string} code
 	 * @returns {Promise} rejects w/ stderr if syntax failure
@@ -284,13 +284,8 @@ export class PythonShell extends EventEmitter{
         return PythonShell.run(filePath, options, callback);
     };
 
-    static getVersion(pythonPath?:string){
-        if(!pythonPath) pythonPath == this.defaultPythonPath
-        let execPromise = promisify(exec)
-        return execPromise(pythonPath + " --version")
-    }
-
     static getVersionSync(pythonPath?:string){
+        if(!pythonPath) pythonPath = this.defaultPythonPath
         return execSync(pythonPath + " --version").toString()
     }
 
diff --git a/test/test-python-shell.ts b/test/test-python-shell.ts
@@ -78,17 +78,6 @@ describe('PythonShell', function () {
         })
     })
 
-    describe("#getVersion", function(){
-        it('should return a string', function(done){
-            PythonShell.getVersion().then(version => {
-                console.log(version)
-                version.stdout.should.be.a.String();
-                version.stdout.length.should.be.greaterThan(0)
-                done()
-            })
-        })
-    })
-
     describe("#getVersionSync", function(){
         it('should return a string', function(){
             const version = PythonShell.getVersionSync()
