Conversation
added 2 commits
December 6, 2024 12:23
aMahanna
commented
Dec 6, 2024
Comment on lines
+137
to
+139
| if "plan" in extra: | ||
| self._plan = extra["plan"] | ||
| result["plan"] = extra["plan"] |
Contributor
Author
There was a problem hiding this comment.
we're starting to blur the lines between camelCase & snake_case results...
plan is a dictionary, with some fields (such as nodes or variables) being list of dictionaries, whose fields can widely vary from each other (i.e one node dictionary may not have the same fields as another node dictionary).
It becomes a slippery slope trying to convert every single field within the nodes & variables dictionaries into snake_case, so I'm opting towards just returning the camelCase fields as-is.
Similar conversation here: #321 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profileparameter indb.aql.executeto2, which returns additionalnodesinformation viacursor.statistics(), along with the query execution plan (newly available viacursor.plan())8.2.0release