feature: host fallback support#184
Merged
Merged
Conversation
(switched to protected syntax)
joowani
reviewed
Dec 5, 2021
joowani
left a comment
joowani
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good start. I left some comments, some of which may not need to be addressed immediately if you are looking to do incremental changes.
Also, I'm not sure how much of this overlaps with active failover in ArangoDB (which python-arango does not have support for yet). I started a thread on it in the past but never got a chance to work on it. Hopefully that helps you in the future.
joowani
reviewed
Dec 7, 2021
aMahanna
changed the title
joowani
approved these changes
Dec 10, 2021
joowani
left a comment
joowani
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
A (working) first-draft implementation for host fallback support.
Requires feedback
What's new:
BaseConnection.process_request()host_indexis still being chosen using the resolver'sget_host_indexmethod.HostResolver.max_tries : intHostResolver.host_count : intRandomHostResolver.get_host_index()