Conversation
# Conflicts: # app/init/constants.php # composer.json # composer.lock # src/Appwrite/Migration/Migration.php # src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/XList.php # src/Appwrite/Platform/Modules/Databases/Http/DocumentsDB/Collections/Documents/Logs/XList.php # src/Appwrite/Platform/Modules/Databases/Http/DocumentsDB/Collections/Logs/XList.php # src/Appwrite/Platform/Modules/Databases/Http/VectorsDB/Collections/Create.php # src/Appwrite/Platform/Modules/Databases/Http/VectorsDB/Collections/Logs/XList.php # src/Appwrite/Utopia/Database/Validator/Queries/Base.php
This comment has been minimized.
This comment has been minimized.
Greptile SummaryThis PR implements "Joins v2" — a new cross-collection join query feature for the Databases API — along with a breaking change to the
Confidence Score: 1/5
Important Files Changed
|
| @@ -61,7 +61,7 @@ | |||
| "utopia-php/compression": "0.1.*", | |||
| "utopia-php/config": "1.*", | |||
| "utopia-php/console": "0.1.*", | |||
There was a problem hiding this comment.
Dev-branch dependencies must not be merged
Both utopia-php/database and utopia-php/migration are pointing at in-progress development branches (dev-joins8 and dev-joins) rather than stable tagged releases. This is expected during active development, but these must be replaced with proper stable semver releases before this PR can be merged into the 1.8.x (production) branch.
"utopia-php/database": "dev-joins8 as 5.3.15",
"utopia-php/migration": "dev-joins as 1.8.0",
The composer.lock also reflects "minimum-stability": "dev" and explicit dev stability flags, which would carry through to any environment that installs from this lockfile.
| colors="true" | ||
| processIsolation="false" |
There was a problem hiding this comment.
stopOnFailure/stopOnError set to true hides downstream test failures
Setting these to true means the test runner halts at the first failing assertion, so any subsequent broken tests will never be reported in CI. This makes it harder to get a complete picture of test health in a PR. The prior false values allowed all tests to run to completion so every failure was visible at once.
If this is intentional (e.g. to speed up a specific debug run), it should be reverted before merging.
| colors="true" | |
| processIsolation="false" | |
| stopOnFailure="false" | |
| stopOnError="false" |
# Conflicts: # composer.json # composer.lock # src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/XList.php # src/Appwrite/Utopia/Database/Validator/Queries/Base.php
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # composer.lock
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist