fix: only execute pageload actions after successfully fetching actions and jscollections in view mode#13521
Merged
ohansFavour merged 2 commits intoreleasefrom May 4, 2022
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
Actions Pod
Bug
Contributor
Author
|
/ok-to-test sha=943e2e4 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2262970802. |
arunvjn
reviewed
May 3, 2022
Contributor
Author
|
/ok-to-test sha=0fb5c8f |
arunvjn
approved these changes
May 3, 2022
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2263183320. |
ohansFavour
deleted the
fix/prevent-execution-of-pageload-actions-before-actions-are-fetched
branch
mohanarpit
added a commit
that referenced
this pull request
May 5, 2022
…s and jscollections in view mode (#13521)
7 tasks
ankitakinger
added a commit
that referenced
this pull request
May 26, 2022
…page (#13950) * fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865) * add debounce to search and remove state var * increase debounce time * fix: updated the condition to show expiry key (#13092) * Add index for git (#13133) * fix: Fixed compile time errors * fix: Unable to see apps in home page after git connect fails (#13387) * Fix Redis installation in Dockerfile (#13428) (#13430) Conflicts: Dockerfile * fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521) * prevent execution of onPageLoad actions before sucessful actions fetch * Perform url update before fetching actions and jscollections (cherry picked from commit 7261834) * fix: NPE check when datasource createdAt is null (cherry picked from commit beafb37) * fixed image alignment for no search results on applications page * deleted duplicate file * reload to Refresh script update * Adding sleep - script fix Co-authored-by: Preet Sidhu <[email protected]> Co-authored-by: Aman Agarwal <[email protected]> Co-authored-by: Abhijeet <[email protected]> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Somangshu Goswami <[email protected]> Co-authored-by: Rimil Dey <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: Favour Ohanekwu <[email protected]> Co-authored-by: Trisha Anand <[email protected]> Co-authored-by: Aishwarya UR <[email protected]>
nayan-rafiq
pushed a commit
that referenced
this pull request
May 30, 2022
…page (#13950) * fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865) * add debounce to search and remove state var * increase debounce time * fix: updated the condition to show expiry key (#13092) * Add index for git (#13133) * fix: Fixed compile time errors * fix: Unable to see apps in home page after git connect fails (#13387) * Fix Redis installation in Dockerfile (#13428) (#13430) Conflicts: Dockerfile * fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521) * prevent execution of onPageLoad actions before sucessful actions fetch * Perform url update before fetching actions and jscollections (cherry picked from commit 7261834) * fix: NPE check when datasource createdAt is null (cherry picked from commit beafb37) * fixed image alignment for no search results on applications page * deleted duplicate file * reload to Refresh script update * Adding sleep - script fix Co-authored-by: Preet Sidhu <[email protected]> Co-authored-by: Aman Agarwal <[email protected]> Co-authored-by: Abhijeet <[email protected]> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Somangshu Goswami <[email protected]> Co-authored-by: Rimil Dey <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: Favour Ohanekwu <[email protected]> Co-authored-by: Trisha Anand <[email protected]> Co-authored-by: Aishwarya UR <[email protected]>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13504
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased