[BasicContainers] Rename reallocate to setCapacity for Rigid and UniqueArray#667
Open
Azoy wants to merge 1 commit into
Open
[BasicContainers] Rename reallocate to setCapacity for Rigid and UniqueArray#667Azoy wants to merge 1 commit into
Azoy wants to merge 1 commit into
Conversation
Update UniqueArray.swift Update UniqueArray.swift
lorentey
approved these changes
Jun 10, 2026
Comment on lines
+95
to
+102
| precondition(newCapacity >= count, "RigidArray capacity overflow") | ||
| guard newCapacity != capacity else { return } | ||
| let newStorage: UnsafeMutableBufferPointer<Element> = .allocate( | ||
| capacity: newCapacity) | ||
| let i = unsafe newStorage.moveInitialize(fromContentsOf: self._items) | ||
| assert(i == count) | ||
| unsafe _storage.deallocate() | ||
| unsafe _storage = newStorage |
Member
There was a problem hiding this comment.
Suggested change
| precondition(newCapacity >= count, "RigidArray capacity overflow") | |
| guard newCapacity != capacity else { return } | |
| let newStorage: UnsafeMutableBufferPointer<Element> = .allocate( | |
| capacity: newCapacity) | |
| let i = unsafe newStorage.moveInitialize(fromContentsOf: self._items) | |
| assert(i == count) | |
| unsafe _storage.deallocate() | |
| unsafe _storage = newStorage | |
| setCapacity(newCapacity) |
Comment on lines
347
to
348
| /// - Parameter newCapacity: The desired new capacity. `newCapacity` must be | ||
| /// greater than or equal to the current count. |
Member
There was a problem hiding this comment.
Suggested change
| /// - Parameter newCapacity: The desired new capacity. The new capacity | |
| /// is set to the maximum of `newCapacity` and the current count. |
Comment on lines
257
to
258
| /// - Parameter newCapacity: The desired new capacity. `newCapacity` must be | ||
| /// greater than or equal to the current count. |
Member
There was a problem hiding this comment.
Suggested change
| /// - Parameter newCapacity: The desired new capacity. The new capacity | |
| /// is set to the maximum of `newCapacity` and the current count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the accepted name of this function in the recent standard library proposal, rename
reallocatehere tosetCapacityas well deprecating the old name.Checklist