Skip to content

Update system-time.yml#12325

Merged
dpgraham merged 2 commits intoappium:masterfrom
ki4070ma:patch-2
Mar 16, 2019
Merged

Update system-time.yml#12325
dpgraham merged 2 commits intoappium:masterfrom
ki4070ma:patch-2

Conversation

@ki4070ma
Copy link
Copy Markdown
Contributor

@ki4070ma ki4070ma commented Mar 16, 2019

Proposed changes

Added api doc for added api

Appium change
appium/appium-base-driver#294

Python client change
appium/python-client#312

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Added new api
Copy link
Copy Markdown
Contributor

@dpgraham dpgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine if you just take out the old code. These samples are meant to be for the latest version.

@ki4070ma
Copy link
Copy Markdown
Contributor Author

@dpgraham Thanks for your comments.
Though both device_time and get_device_time() are available on the latest, should I remove the old code? Or is it ok just to remove below comment?

# Available since Appium 1.11.0 and Appium-Python-Client v0.35

@dpgraham
Copy link
Copy Markdown
Contributor

Ok. Yeah just remove the comment.

@dpgraham dpgraham merged commit 69e9e79 into appium:master Mar 16, 2019
@ki4070ma ki4070ma deleted the patch-2 branch March 16, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants