fix: fix convert relative link to absolute in enqueue_links for response with redirect#956
Merged
vdusek merged 3 commits intoapify:masterfrom Feb 4, 2025
Merged
Conversation
Mantisus
changed the title
enqueue_links for response with redirectenqueue_links for response with redirect
vdusek
approved these changes
Feb 3, 2025
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Any idea for a test? Couldn't we utilize httpbin? ... if there is no easy way, it is not necessary I would say. Otherwise LGTM 🙂.
Collaborator
I agree it would be nice to have a test for it to properly describe the scenario in which this is a problem. Maybe something from https://httpbin.org/#/Redirects can be used to create such scenario? |
Collaborator
Author
|
Updated the current test for |
vdusek
approved these changes
Feb 3, 2025
Pijukatel
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enqueue_linksfor response with redirect.Issues