fix: Fix templates - poetry-plugin-export version and camoufox template name#952
Merged
fix: Fix templates - poetry-plugin-export version and camoufox template name#952
Conversation
Pijukatel
added
bug
Pijukatel
changed the title
This is optimization, otherwise those files will be automatically fetched on each image start.
janbuchar
approved these changes
Feb 3, 2025
Collaborator
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
LGTM, but please make a follow up issue to update to poetry 2
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add poetry-plugin-export version constraint <1.9 to make it compatible with already constrained version of poetry <2
(poetry-plugin-export>=1.9 works only with poetry version >=2)
Fix incorrect camoufox cookiecutter template name in several template files 'camoufox' -> 'playwright-camoufox'
Issues