Skip to content

fix: Fix crawler not retrying user handler if there was timeout in the handler#909

Merged
Pijukatel merged 2 commits intomasterfrom
user-handler-timeout
Jan 17, 2025
Merged

fix: Fix crawler not retrying user handler if there was timeout in the handler#909
Pijukatel merged 2 commits intomasterfrom
user-handler-timeout

Conversation

@Pijukatel
Copy link
Copy Markdown
Collaborator

@Pijukatel Pijukatel commented Jan 15, 2025

Description

Fix crawler not retrying user handler if there was timeout in the handler.
Add parametrized test with one parameter set skipped with reason #908

Issues

@Pijukatel Pijukatel added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 15, 2025
@Pijukatel Pijukatel changed the title fix: Fix crawler not retrying user handler if there was timeout in the handler. fix: Fix crawler not retrying user handler if there was timeout in the handler Jan 15, 2025
@github-actions github-actions bot added this to the 106th sprint - Tooling team milestone Jan 15, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jan 15, 2025
Test uses asyncio.timeout that was introduced in 3.11
@Pijukatel Pijukatel force-pushed the user-handler-timeout branch from d3efc41 to 25106d3 Compare January 15, 2025 13:50
@Pijukatel Pijukatel marked this pull request as ready for review January 15, 2025 13:55
@Pijukatel Pijukatel requested review from janbuchar and vdusek January 15, 2025 13:57
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Pijukatel Pijukatel merged commit f4090ef into master Jan 17, 2025
@Pijukatel Pijukatel deleted the user-handler-timeout branch January 17, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timeout in user defined handler should cause retry

3 participants