test: Add a test of redirect handling in PlaywrightCrawler#873
Merged
test: Add a test of redirect handling in PlaywrightCrawler#873
Conversation
janbuchar
added
t-tooling
github-actions
bot
added
the
tested
Pijukatel
reviewed
Jan 6, 2025
| async def request_handler(context: PlaywrightCrawlingContext) -> None: | ||
| handled_urls.add(context.request.loaded_url or '') | ||
|
|
||
| request = Request.from_url( |
Collaborator
There was a problem hiding this comment.
I would suggest to add a comment that describes this very specific behavior of httpbin site, that creates redirect based on this specific query parameter.
Maybe add link. To me most readable was https://httpbin.org/legacy (but maybe there is better)
vdusek
approved these changes
Jan 6, 2025
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
I would appreacite some explanatory comments as well, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.