refactor!: Rename PlaywrightCrawler kwargs: browser_options, page_options#831
Merged
refactor!: Rename PlaywrightCrawler kwargs: browser_options, page_options#831
Conversation
Motivation is for the names to match their actual usage. Rename them also in internal components. Change PlaywrightBrowserController close method to rely on context to close pages, as per PW documentation recommendations.
Pijukatel
added
t-tooling
github-actions
bot
added
the
tested
Pijukatel
commented
Dec 19, 2024
Pijukatel
commented
Dec 19, 2024
vdusek
reviewed
Dec 19, 2024
vdusek
reviewed
Dec 19, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
There are still the old names in PlaywrightBrowserController._create_browser_context.
Co-authored-by: Vlada Dusek <[email protected]>
Update more docstrings. Enable use of browser_new_context_options['proxy'].
vdusek
requested changes
Dec 19, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Please write down the breaking changes - to the upgrading guide and copy them to the PR description as well, thanks.
vdusek
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation is for the names to match their actual usage. Rename them also in internal components.
Change
PlaywrightBrowserController.closemethod to rely on context to close pages, as per PW documentation recommendations.Breaking changes
PlaywrightCrawler.__init__keyword arguments:browser_optionstobrowser_launch_options,page_optionstobrowser_new_context_options.PlaywrightBrowserPlugin,BaseBrowserPlugin,PlaywrightBrowserController,BaseBrowserControllerin all methods where previously named arguments were present.