Skip to content

feat: Expose event types, improve on/emit signature, allow parameterless listeners#800

Merged
janbuchar merged 6 commits intomasterfrom
improve-event-types
Dec 16, 2024
Merged

feat: Expose event types, improve on/emit signature, allow parameterless listeners#800
janbuchar merged 6 commits intomasterfrom
improve-event-types

Conversation

@janbuchar
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar commented Dec 10, 2024

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 10, 2024
@github-actions github-actions bot added this to the 104th sprint - Tooling team milestone Dec 10, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Dec 10, 2024
@janbuchar janbuchar requested a review from vdusek December 16, 2024 14:12
@Pijukatel Pijukatel self-requested a review December 16, 2024 14:42
@janbuchar janbuchar merged commit c102c4c into master Dec 16, 2024
@janbuchar janbuchar deleted the improve-event-types branch December 16, 2024 16:07
@B4nan
Copy link
Copy Markdown
Member

B4nan commented Dec 17, 2024

If you wanted to close both of the issue listed in the description, you need to have Closes #... for both of them. The second issue is still opened now.

@janbuchar
Copy link
Copy Markdown
Collaborator Author

If you wanted to close both of the issue listed in the description, you need to have Closes #... for both of them. The second issue is still opened now.

I wanted it this way - the second one is waiting for SDK to start using Crawlee 0.5.

vdusek pushed a commit to apify/apify-sdk-python that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose possible event types from crawlee._events

4 participants