feat: Add pre-navigation hooks router to AbstractHttpCrawler#791
Merged
feat: Add pre-navigation hooks router to AbstractHttpCrawler#791
Conversation
This makes it possible for users to register their hooks for http based crawlers. Add tests. Update docs.
Pijukatel
added
enhancement
github-actions
bot
added
the
tested
Pijukatel
commented
Dec 10, 2024
| """Create static content crawler context pipeline with expected pipeline steps.""" | ||
| return ( | ||
| ContextPipeline() | ||
| .compose(self._execute_pre_navigation_hooks) |
Collaborator
Author
There was a problem hiding this comment.
It does not need to be it's own pipeline step. It can be part of _make_http_request. This makes it maybe more readable.
janbuchar
reviewed
Dec 11, 2024
Collaborator
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Some minor issues, looks good otherwise
| """Create static content crawler context pipeline with expected pipeline steps.""" | ||
| return ( | ||
| ContextPipeline() | ||
| .compose(self._execute_pre_navigation_hooks) |
Co-authored-by: Jan Buchar <[email protected]>
janbuchar
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes it possible for users to register their pre-navigation hooks for http based crawlers.
Add tests.
Update docs.
Issues
preNavigationHooksin crawlers other thanPlaywrightCrawler#635