Skip to content

fix: respect custom HTTP headers in PlaywrightCrawler#685

Merged
vdusek merged 4 commits intoapify:masterfrom
Mantisus:playwright-user-headers
Nov 12, 2024
Merged

fix: respect custom HTTP headers in PlaywrightCrawler#685
vdusek merged 4 commits intoapify:masterfrom
Mantisus:playwright-user-headers

Conversation

@Mantisus
Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus commented Nov 12, 2024

Description

add Request.headers support for PlaywrightCrawler.

Testing

The test uses `'https://httpbin.org/get' to ensure that the headers have been installed

Checklist

  • CI passed

@vdusek vdusek changed the title Fix: Add support custom headers for playwright requests fix: Add support custom headers for playwright requests Nov 12, 2024
@vdusek vdusek changed the title fix: Add support custom headers for playwright requests fix: Add support custom headers for Playwright requests Nov 12, 2024
@vdusek vdusek requested review from janbuchar and vdusek November 12, 2024 11:12
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details, otherwise it's great, thank you! 🙂

@vdusek vdusek added this to the 102nd sprint - Tooling team milestone Nov 12, 2024
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. bug Something isn't working. labels Nov 12, 2024
@vdusek vdusek changed the title fix: Add support custom headers for Playwright requests fix: Add support for custom HTTP headers in PlaywrightCrawler Nov 12, 2024
@B4nan B4nan changed the title fix: Add support for custom HTTP headers in PlaywrightCrawler fix: respect custom HTTP headers in PlaywrightCrawler Nov 12, 2024
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit a84125f into apify:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants