feat: Add BeautifulSoupParser type alias#674
Conversation
github-actions
bot
added
the
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Sure, this makes sense. Could you consider reexporting the new type so that you can import it without accessing private subpackages?
B4nan
changed the title
Sure. Just a tiny question. What is the established practice here with _all_? I know it is for star imports, but do you put all stuff inside or just some selected top level stuff? |
|
You should include only names that are part of the "public interface" of the package in |
To avoid repeating same Literal definitions.
Pijukatel
force-pushed
the
define-bs-parser
branch
from
8986fd5 to
4c28b49
Compare
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
Pijukatel
changed the title
There was a problem hiding this comment.
If issue is not linked to the pull request then estimate the pull request!
|
I will also add that the |
vdusek
changed the title
|
@Pijukatel And I will add this - it's a nice read: https://mkdocstrings.github.io/griffe/guide/users/recommendations/public-apis/ |
Pijukatel
changed the title
vdusek
changed the title
3 participants
Description
To avoid repeating same Literal definitions.
Checklist