feat: Added get_public_url method to KeyValueStore#572
Conversation
|
This looks like the right approach. You should use the |
@janbuchar Thanks for the review and hint :) I have updated the PR with storage_dir |
src/crawlee/base_storage_client/_base_key_value_store_client.py
Outdated
Show resolved
Hide resolved
src/crawlee/base_storage_client/_base_key_value_store_client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Buchar <[email protected]>
Co-authored-by: Jan Buchar <[email protected]>
src/crawlee/base_storage_client/_base_key_value_store_client.py
Outdated
Show resolved
Hide resolved
|
@akshay11298 sorry for the broken CI. I confirm that code quality checks are passing on my machine. |
|
@janbuchar @vdusek found the cause of the error. It was the slash used when creating the path manually. Used os.path.join to fix the error Edit: |
|
@janbuchar @vdusek Now the test passes. urlparse was returning netloc in windows and path in mac/linux |
src/crawlee/base_storage_client/_base_key_value_store_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, @akshay11298, for solving it. I added one more test, test_get_public_url_raises_for_non_existing_key, and updated the method a bit so that it passes. LGTM.


Description
Issues
KeyValueStore.get_public_url#514Testing
Checklist