Skip to content

feat: implement BasicCrawler#56

Merged
janbuchar merged 48 commits intomasterfrom
basic-crawler
Apr 10, 2024
Merged

feat: implement BasicCrawler#56
janbuchar merged 48 commits intomasterfrom
basic-crawler

Conversation

@janbuchar
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar requested a review from vdusek February 29, 2024 15:37
@github-actions github-actions bot added this to the 84th sprint - Tooling team milestone Feb 29, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Feb 29, 2024
@janbuchar janbuchar requested a review from vdusek April 9, 2024 10:44
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of comments, however, a lot of them should be easy fixes. Great job otherwise!

@janbuchar janbuchar requested a review from vdusek April 9, 2024 16:27
@janbuchar janbuchar requested a review from vdusek April 10, 2024 07:59
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit 6da971f into master Apr 10, 2024
@janbuchar janbuchar deleted the basic-crawler branch April 10, 2024 08:47
@B4nan
Copy link
Copy Markdown
Member

B4nan commented Apr 10, 2024

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement BasicCrawler

3 participants