Skip to content

feat: add header generator and integrate it into HTTPX client#530

Merged
vdusek merged 3 commits intomasterfrom
add-fingerprint-generator
Sep 17, 2024
Merged

feat: add header generator and integrate it into HTTPX client#530
vdusek merged 3 commits intomasterfrom
add-fingerprint-generator

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Sep 16, 2024 •
edited
Loading

Description

  • This is the first version of the header generator, providing common HTTP headers including user agent.
    • User-agent is picked randomly from a random pool of 1000 user agents from the Apify fingerprint dataset.
  • This is integrated into the HTTPX client and will be further used in the Playwright fingerprint injector (Mask Playwright's "headless" headers #401).

Issues

Testing

  • New unit tests implemented.

Checklist

  • CI passed

@github-actions github-actions bot added this to the 98th sprint - Tooling team milestone Sep 16, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 16, 2024
@vdusek vdusek force-pushed the add-fingerprint-generator branch from 90b1cab to 4d8abcc Compare September 16, 2024 15:59
github-actions[bot]
github-actions bot reviewed Sep 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek changed the title feat: add fingerprint generator and integrate it into HTTPX client [WIP] feat: add header generator and integrate it into HTTPX client [WIP] Sep 17, 2024
@vdusek vdusek force-pushed the add-fingerprint-generator branch from 4d8abcc to 50f34e1 Compare September 17, 2024 08:53
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Sep 17, 2024
@vdusek vdusek changed the title feat: add header generator and integrate it into HTTPX client [WIP] feat: add header generator and integrate it into HTTPX client Sep 17, 2024
@vdusek vdusek marked this pull request as ready for review September 17, 2024 08:57
@vdusek vdusek requested a review from janbuchar September 17, 2024 08:57
janbuchar
janbuchar reviewed Sep 17, 2024
View reviewed changes
@vdusek vdusek requested a review from janbuchar September 17, 2024 11:03
janbuchar
janbuchar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit b63f9f9 into master Sep 17, 2024
@vdusek vdusek deleted the add-fingerprint-generator branch September 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

98th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Add header generator and integrate it into HTTPX client

2 participants

@vdusek @janbuchar