Conversation
janbuchar
added
the
t-tooling
github-actions
bot
added
the
tested
vdusek
reviewed
Sep 2, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Good job. Just a couple of questions:
-
Shouldn't we handle this in BS crawler as well?
-
What about adding try-except block when parsing the response? (Same for BS crawler.)
try:
parsel_selector = await asyncio.to_thread(lambda: Selector(body=context.http_response.read()))
except ValueError as exc:
raise ValueError(
f'Failed to parse the response body. Ensure the response is parseble via Parsel: {exc}'
) from exc
Collaborator
Author
I'm not sure how to go about that. BS is super tolerant to malformed HTML: >>> from bs4 import BeautifulSoup
>>> BeautifulSoup('{"hello": "world"}')
<html><body><p>{"hello": "world"}</p></body></html>So... let me propose employing the Ostrich algorithm yet again?
Are you sure the original exception is not clear enough? This will make the traceback longer, which is not great for readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @Ehsan-U for reporting this!