Skip to content

feat: curl http client selects chrome impersonation by default#473

Merged
vdusek merged 2 commits intomasterfrom
turn-on-impersonate-by-default-for-curl-client
Aug 29, 2024
Merged

feat: curl http client selects chrome impersonation by default#473
vdusek merged 2 commits intomasterfrom
turn-on-impersonate-by-default-for-curl-client

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Aug 29, 2024

Description

  • CurlImpersonateHttpClient selects chrome browser type for impersonation by default.
  • Before:
{
    "url": "https://httpbin.org/get",
    "response": {
        "args": {},
        "headers": {
            "Accept": "*/*",
            "Accept-Encoding": "gzip, deflate, br",
            "Content-Type": "application/x-www-form-urlencoded",
            "Host": "httpbin.org",
            "X-Amzn-Trace-Id": "Root=1-66d04355-5df0396b08e2931c125389aa"
        },
        "origin": "78.80.81.196",
        "url": "https://httpbin.org/get"
    }
}
  • After:
{
    "url": "https://httpbin.org/get",
    "response": {
        "args": {},
        "headers": {
            "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7",
            "Accept-Encoding": "gzip, deflate, br, zstd",
            "Accept-Language": "en-US,en;q=0.9",
            "Content-Type": "application/x-www-form-urlencoded",
            "Host": "httpbin.org",
            "Priority": "u=0, i",
            "Sec-Ch-Ua": "\"Chromium\";v=\"124\", \"Google Chrome\";v=\"124\", \"Not-A.Brand\";v=\"99\"",
            "Sec-Ch-Ua-Mobile": "?0",
            "Sec-Ch-Ua-Platform": "\"macOS\"",
            "Sec-Fetch-Dest": "document",
            "Sec-Fetch-Mode": "navigate",
            "Sec-Fetch-Site": "none",
            "Sec-Fetch-User": "?1",
            "Upgrade-Insecure-Requests": "1",
            "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36",
            "X-Amzn-Trace-Id": "Root=1-66d04c27-057e04e635efbbde18e0d85b"
        },
        "origin": "78.80.81.196",
        "url": "https://httpbin.org/get"
    }
}

Issues

  • N/A

Testing

  • N/A

Checklist

  • CI passed

@vdusek vdusek added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Aug 29, 2024
@vdusek vdusek added this to the 97th sprint - Tooling team milestone Aug 29, 2024
@vdusek vdusek requested a review from janbuchar August 29, 2024 10:24
@vdusek vdusek self-assigned this Aug 29, 2024
@vdusek vdusek changed the title feat: curl http client selects random impersonation by default feat: curl http client selects chrome impersonation by default Aug 29, 2024
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 82dc939 into master Aug 29, 2024
@vdusek vdusek deleted the turn-on-impersonate-by-default-for-curl-client branch August 29, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants