Conversation
janbuchar
added
t-tooling
B4nan
approved these changes
Aug 7, 2024
Member
B4nan
left a comment
B4nan
left a comment
There was a problem hiding this comment.
can we add a test case for this maybe? so its clear how it looks
Collaborator
Author
We can, but should we? It sounds both flaky and fragile... |
Member
|
Well, I don't want any flaky tests, but you can mock everything out. My idea was a simple unit test where you log predefined stats and assert how they were logged. |
github-actions
bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.