Skip to content

feat: add URL validation#343

Merged
vdusek merged 5 commits intomasterfrom
add-url-validator
Jul 23, 2024
Merged

feat: add URL validation#343
vdusek merged 5 commits intomasterfrom
add-url-validator

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Jul 22, 2024

Description

  • Add HttpUrl Pydantic type for URLs - URL validation.
  • A lot of tests had to be adjusted.
  • Some changes regarding relative/absolute URLs had to be implemented as well.

Issues

Testing

  • N/A

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@vdusek vdusek requested a review from janbuchar July 22, 2024 16:25
@vdusek vdusek force-pushed the add-url-validator branch from a6f4471 to 5dfe0b0 Compare July 23, 2024 09:28
@github-actions github-actions bot added this to the 94th sprint - Tooling team milestone Jul 23, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Jul 23, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek changed the title feat: add URL validator feat: add URL validation Jul 23, 2024
@vdusek vdusek force-pushed the add-url-validator branch from 8b6450d to b440771 Compare July 23, 2024 11:18
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek marked this pull request as ready for review July 23, 2024 11:25
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have been pretty tedious. I'm sure it's a step in the right direction though, good job. Please see my comments.

@janbuchar janbuchar self-requested a review July 23, 2024 13:49
@vdusek vdusek merged commit 1514538 into master Jul 23, 2024
@vdusek vdusek deleted the add-url-validator branch July 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add URL validation

2 participants