feat: Maintain a global configuration instance#207
Conversation
vdusek
left a comment
There was a problem hiding this comment.
What about a simple test case testing if it's called multiple times it always returns the object with the same ID? Or it's not necessary?
Good point. Also we'll need to reset the global instance before each test, I guess. |
vdusek
left a comment
There was a problem hiding this comment.
Just a thought on the naming...
I suggest using get_global instead of get_global_configuration. Since the method serves as constructor for the Configuration class - including "configuration" in the method name seems redundant. Leaving it up to you.
Otherwise, LGTM.
I was ready to tell you that it's named that way because of JS crawlee, but there it's called |
No description provided.