fix: Correct return type of storage get_info methods#200
Merged
Conversation
janbuchar
added
t-tooling
vdusek
approved these changes
Jun 20, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Just fix the docstrings, otherwise LGTM, thanks.
| """Get an object containing general information about the key value store. | ||
|
|
||
| Returns: | ||
| Object returned by calling the GET key value store API endpoint. |
Collaborator
There was a problem hiding this comment.
This statement is incorrect. The storage should be client-agnostic, so we need something more generic. The same applies to other storages as well.
I know you probably didn't write this, but please fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.