Skip to content

fix: tmp path in tests is working#164

Merged
vdusek merged 4 commits intomasterfrom
fix-tmp-path-for-tests
May 31, 2024
Merged

fix: tmp path in tests is working#164
vdusek merged 4 commits intomasterfrom
fix-tmp-path-for-tests

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 30, 2024

Description

  • Resolved the issue with temporary paths in tests by ensuring the CRAWLEE_LOCAL_STORAGE_DIR environment variable is set before the Config instantiation.
  • Added ipdb debugger as a development dependency.

Related issues

Testing

  • Try to run tests locally.

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@github-actions github-actions bot added this to the 90th sprint - Tooling team milestone May 30, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels May 30, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek requested a review from janbuchar May 31, 2024 09:39
@vdusek vdusek marked this pull request as ready for review May 31, 2024 09:39
@vdusek vdusek merged commit 382b6f4 into master May 31, 2024
@vdusek vdusek deleted the fix-tmp-path-for-tests branch May 31, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix not working tmp path in unit tests

2 participants