Skip to content

fix: storage manager & purging the defaults#150

Merged
vdusek merged 3 commits intomasterfrom
storages-purging
May 13, 2024
Merged

fix: storage manager & purging the defaults#150
vdusek merged 3 commits intomasterfrom
storages-purging

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 13, 2024

Description

  • Auto-purging of default storages was already implemented. I just checked it how/if it works, how it works with more instances of storages, and updated the StorageManager to be singleton-like.

Related issues

Testing

  • Covered by unit-tests

@github-actions github-actions bot added this to the 89th sprint - Tooling team milestone May 13, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels May 13, 2024
@vdusek vdusek requested a review from janbuchar May 13, 2024 12:33
@vdusek vdusek marked this pull request as ready for review May 13, 2024 12:33
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 851042f into master May 13, 2024
@vdusek vdusek deleted the storages-purging branch May 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants