Skip to content

feat: add base storage client and resource subclients#138

Merged
vdusek merged 2 commits intomasterfrom
storages-v2
May 2, 2024
Merged

feat: add base storage client and resource subclients#138
vdusek merged 2 commits intomasterfrom
storages-v2

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Apr 30, 2024

Description

  • Add the BaseStorage client and resource sub-clients based on the ApifyClient.
  • Our existing storage clients (only MemoryStorageClient) inherit the base class and implement relevant methods.

Related issues

Testing

  • Current tests cover the changes.

@github-actions github-actions bot added this to the 88th sprint - Tooling team milestone Apr 30, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 30, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek changed the title Add BaseStorage client and resource sub-clients feat: Add BaseStorage client and resource sub-clients Apr 30, 2024
@vdusek vdusek changed the title feat: Add BaseStorage client and resource sub-clients feat: add base storage client and resource sub-clients Apr 30, 2024
@vdusek vdusek marked this pull request as ready for review April 30, 2024 16:37
@vdusek vdusek requested a review from janbuchar April 30, 2024 16:37
@vdusek vdusek changed the title feat: add base storage client and resource sub-clients feat: add base storage client and resource subclients May 1, 2024
Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool!

@vdusek vdusek requested a review from janbuchar May 2, 2024 11:04
@vdusek vdusek merged commit 44d6597 into master May 2, 2024
@vdusek vdusek deleted the storages-v2 branch May 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants