Conversation
janbuchar
added
the
t-tooling
| next_index: Annotated[int, Field(alias='nextIndex')] = 0 | ||
| next_unique_key: Annotated[str | None, Field(alias='nextUniqueKey')] = None | ||
| in_progress: Annotated[set[str], Field(alias='inProgress')] = set() |
There was a problem hiding this comment.
Are the camelCase aliases necessary? AFAIK I also did not use them in FS storage clients.
There was a problem hiding this comment.
Probably not. Sessions and Statistics (other instances of recoverable state) use them too. I have no strong opinion here, if you do, say the word and I'll remove them.
There was a problem hiding this comment.
Well, so currently somewhere we use them, and somewhere we don't - up to you then.
github-actions
bot
added
the
tested
|
The request data snapshotting is pretty inefficient - it loads the whole thing into memory (same as the JS version) and stores it uncompressed in the key-value store (JS version uses gzip). After quite some trial and error, I believe we can use Ostrich algorithm now and optimize if it proves necessary. |
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Some small comments and one more serious about the test.
4 participants
RequestList#99