fix: Do not raise an error to check 'same-domain' if there is no hostname in the url#1251
Merged
vdusek merged 3 commits intoapify:masterfrom Jun 19, 2025
Merged
fix: Do not raise an error to check 'same-domain' if there is no hostname in the url#1251vdusek merged 3 commits intoapify:masterfrom
vdusek merged 3 commits intoapify:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the behavior of the same-domain enqueue strategy to return False instead of raising an error when either URL lacks a hostname, preventing exceptions on invalid URLs.
- Replace
ValueErrorwith a silent skip (return False) for missing hostnames in same-domain checks. - Ensures
extract_linkscan apply the enqueue strategy without erroring on malformed URLs.
Comments suppressed due to low confidence (2)
src/crawlee/crawlers/_basic/_basic_crawler.py:970
- Add a unit test for the case where
origin_url.hostnameortarget_url.hostnameisNonewith thesame-domainstrategy to verify that it returnsFalseand does not enqueue.
return False
src/crawlee/crawlers/_basic/_basic_crawler.py:967
- Update the method docstring for
_check_enqueue_strategyto document that URLs without hostnames will simply returnFalsefor thesame-domainstrategy instead of raising an error.
def _check_enqueue_strategy(
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extract_linksand can be applied to invalid urls.