fix: fix handle error without args in _get_error_message for ErrorTracker#1181
Merged
Pijukatel merged 2 commits intoapify:masterfrom Apr 29, 2025
Merged
fix: fix handle error without args in _get_error_message for ErrorTracker#1181Pijukatel merged 2 commits intoapify:masterfrom
args in _get_error_message for ErrorTracker#1181Pijukatel merged 2 commits intoapify:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error message handling within ErrorTracker, ensuring that errors without message data in args are handled correctly by falling back to the previous error’s message from context or the error class name.
- Updated error message logic in _get_error_message to support errors without message arguments.
- Adjusted test expectations and added a new test for errors raised in a chain.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/_statistics/test_error_tracker.py | Updated expected error counts and added a new test for error chains. |
| src/crawlee/statistics/_error_tracker.py | Modified _get_error_message to correctly handle errors without args. |
Mantisus
changed the title
args in _get_error_message for ErrorTrackerargs in _get_error_message for ErrorTracker
Co-authored-by: Copilot <[email protected]>
Pijukatel
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
args. If the error was raised in a chain, tries to get the previous error message from__context__. Otherwise uses the error class name as the message.Issues
ErrorTrackerin specific error handling cases #1179Testing