Skip to content

fix: update project templates for Poetry v2.x compatibility#1049

Merged
vdusek merged 2 commits intoapify:masterfrom
Mantisus:relax-poetry-template
Mar 6, 2025
Merged

fix: update project templates for Poetry v2.x compatibility#1049
vdusek merged 2 commits intoapify:masterfrom
Mantisus:relax-poetry-template

Conversation

@Mantisus
Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus commented Mar 5, 2025

Description

  • Relax version poetry in template

Issues

@Mantisus Mantisus requested review from Pijukatel and vdusek March 5, 2025 00:48
@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented Mar 5, 2025

I tested the current templates with poetry 2.1.1 and found no problems.

If we want to add templates for uv, I think it should be done in a separate PR

@Mantisus Mantisus self-assigned this Mar 5, 2025
@janbuchar
Copy link
Copy Markdown
Collaborator

I tested the current templates with poetry 2.1.1 and found no problems.

Awesome, does the dockerfile for deployment to apify still work?

If we want to add templates for uv, I think it should be done in a separate PR

100% agree

Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please use the PEP-621 format for the pyproject.toml? Poetry supports it from v2, so in that case, there should be a bottom version constraint as well.

@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented Mar 5, 2025

Awesome, does the dockerfile for deployment to apify still work?

Yep. Locally it runs correctly for beautifulsoup, parsel and camoufox. There is a problem for Playwright, but it is not poetry related

Playwright requires or modification of the docker template since I get the error
Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
Or running with the browser_launch_options={'args': ['--no-sandbox']} for PlaywrightCrawler.
Or using firefox as the browser in the template - I'd prefer this option

@Mantisus
Copy link
Copy Markdown
Collaborator Author

Mantisus commented Mar 5, 2025

Could we please use the PEP-621 format for the pyproject.toml? Poetry supports it from v2, so in that case, there should be a bottom version constraint as well.

Updated :)

@Mantisus Mantisus requested a review from vdusek March 5, 2025 13:58
Copy link
Copy Markdown
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀, thanks

@vdusek vdusek changed the title chore: relax version poetry in project templates fix: update project templates for Poetry v2.x compatibility Mar 6, 2025
@vdusek vdusek added this to the 109th sprint - Tooling team milestone Mar 6, 2025
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 6, 2025
@vdusek vdusek merged commit 96dc2f9 into apify:master Mar 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate project templates to poetry 2.x.x

3 participants