Skip to content

fix: Fix flaky test_common_headers_and_user_agent#1030

Merged
Pijukatel merged 2 commits intomasterfrom
flaky-coommon-headers-test
Feb 28, 2025
Merged

fix: Fix flaky test_common_headers_and_user_agent#1030
Pijukatel merged 2 commits intomasterfrom
flaky-coommon-headers-test

Conversation

@Pijukatel
Copy link
Copy Markdown
Collaborator

@Pijukatel Pijukatel commented Feb 27, 2025

Description

In header network(source for generated headers) possible values for accept are under two separate keys. Use both in tests.

Issues

@Pijukatel Pijukatel added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 27, 2025
@github-actions github-actions bot added this to the 109th sprint - Tooling team milestone Feb 27, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 27, 2025
@Pijukatel Pijukatel requested a review from Mantisus February 27, 2025 12:08
@Pijukatel Pijukatel marked this pull request as ready for review February 27, 2025 12:08
Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mantisus
Copy link
Copy Markdown
Collaborator

Looks like the new redirect tests are crashing on our httpbin instance...

@Pijukatel Pijukatel merged commit 58aa70e into master Feb 28, 2025
23 checks passed
@Pijukatel Pijukatel deleted the flaky-coommon-headers-test branch February 28, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flakiness in test_common_headers_and_user_agent

2 participants