fix: Remove allow_redirects override in CurlImpersonateHttpClient#1017
fix: Remove allow_redirects override in CurlImpersonateHttpClient#1017Pijukatel merged 4 commits intoapify:masterfrom
Conversation
There was a problem hiding this comment.
Hi, thanks for the PR. Could you please add two tests that will set both possible values of allow_redirects in async_session_kwargs for CurlImpersonateHttpClient. For the test case maybe you can use some redirects endpoint of the httpbin that we use in the existing tests.
Response for the same endpoint should depend on the value of this option. So you can do assert on that.
|
@Pijukatel Added tests 👍 @Mantisus I think a bug was introduced here: a3a2b4f#diff-e903cf8755c3a2c00152eb47c7a8e47f7c1f3c91eef13b303f40927597048db3R82 I've stumbled on it while adding tests: return HttpHeaders({key: value for key, value in self._response.headers if value})
|
oh, thanks for catching that. I missed it. 😟 |
3 participants
Description
Allow users to disable redirect following for CurlImpersonateHttpClient.
Issues
Testing
Not sure how to properly tests this. This is a default behaviour for underlying
AsyncSession.Checklist