chore: fix tests and improve tests stability#1007
Merged
vdusek merged 4 commits intoapify:masterfrom Feb 21, 2025
Merged
Conversation
This was referenced Feb 21, 2025
Mantisus
changed the title
Pijukatel
approved these changes
Feb 21, 2025
tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
Show resolved
Hide resolved
vdusek
reviewed
Feb 21, 2025
Comment on lines
+79
to
+83
| @pytest.fixture | ||
| async def key_value_store() -> AsyncGenerator[KeyValueStore, None]: | ||
| kvs = await KeyValueStore.open() | ||
| yield kvs | ||
| await kvs.drop() |
Collaborator
There was a problem hiding this comment.
Just wondering whether to put this into conftest and utilize this fixture across different test modules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kvsisolation in theuse_statetest forAdaptivePlaywrightCrawlerhttpxandcurl. Havinghttpxuserespxinstead ofhttpbinwill increase the stability of the test.PlaywrightCrawlertests to userouteinstead ofhttpbin. This will speed up execution time and improve stability. It will also probably be useful for Prepare universal http interceptor for both static and browser crawlers tests #929 in future