refactor!: declare private and public interface#456
Merged
Conversation
vdusek
added
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
Contributor
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
vdusek
force-pushed
the
define-private-and-public-modules
branch
from
35dfde7 to
ea3e1de
Compare
vdusek
force-pushed
the
define-private-and-public-modules
branch
from
ea3e1de to
f966400
Compare
1 task
vdusek
added a commit
that referenced
this pull request
Aug 26, 2024
### Description - refactor: storage-related models are in base storage client - basically I just split `crawlee/_models.py` to `crawlee/_request.py` and `crawlee.base_storage_client._models.py` ### Issues - Just a follow-up of #456 ### Testing - Tests are passing ### Checklist - [x] CI passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Testing
Checklist