chore: Forgotten review comments (#709)

janbuchar · web-flow · commit a17b3b11b028 · 2024-11-18T16:27:02.000+01:00
part of #167 that I forgot to push - sorry @vdusek
diff --git a/src/crawlee/beautifulsoup_crawler/_beautifulsoup_crawler.py b/src/crawlee/beautifulsoup_crawler/_beautifulsoup_crawler.py
@@ -147,6 +147,8 @@ async def _handle_blocked_request(
         if self._retry_on_blocked:
             status_code = context.http_response.status_code
 
+            # TODO: refactor to avoid private member access
+            # https://github.com/apify/crawlee-python/issues/708
             if (
                 context.session
                 and status_code not in self._http_client._ignore_http_error_status_codes  # noqa: SLF001
diff --git a/src/crawlee/http_crawler/_http_crawler.py b/src/crawlee/http_crawler/_http_crawler.py
@@ -127,6 +127,8 @@ async def _handle_blocked_request(self, context: HttpCrawlingContext) -> AsyncGe
         if self._retry_on_blocked:
             status_code = context.http_response.status_code
 
+            # TODO: refactor to avoid private member access
+            # https://github.com/apify/crawlee-python/issues/708
             if (
                 context.session
                 and status_code not in self._http_client._ignore_http_error_status_codes  # noqa: SLF001
diff --git a/src/crawlee/parsel_crawler/_parsel_crawler.py b/src/crawlee/parsel_crawler/_parsel_crawler.py
@@ -140,6 +140,8 @@ async def _handle_blocked_request(
         if self._retry_on_blocked:
             status_code = context.http_response.status_code
 
+            # TODO: refactor to avoid private member access
+            # https://github.com/apify/crawlee-python/issues/708
             if (
                 context.session
                 and status_code not in self._http_client._ignore_http_error_status_codes  # noqa: SLF001
diff --git a/tests/unit/browsers/test_playwright_browser_controller.py b/tests/unit/browsers/test_playwright_browser_controller.py
@@ -46,7 +46,7 @@ async def test_initial_state(browser: Browser) -> None:
 
 async def test_open_and_close_page(controller: PlaywrightBrowserController, httpbin: URL) -> None:
     page = await controller.new_page()
-    await page.goto(f'{httpbin}')
+    await page.goto(str(httpbin))
 
     assert page in controller.pages
     assert controller.pages_count == 1
diff --git a/tests/unit/playwright_crawler/test_playwright_crawler.py b/tests/unit/playwright_crawler/test_playwright_crawler.py
@@ -165,6 +165,6 @@ async def test_pre_navigation_hook(httpbin: URL) -> None:
     async def request_handler(_context: PlaywrightCrawlingContext) -> None:
         pass
 
-    await crawler.run(['https://example.com', f'{httpbin}'])
+    await crawler.run(['https://example.com', str(httpbin)])
 
     assert mock_hook.call_count == 2
