refactor!: Make Actor initialization stricter and more predictable#576
Merged
refactor!: Make Actor initialization stricter and more predictable#576
Actor initialization stricter and more predictable#576Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Actorare initialized inasync init,not in__init__.Actoris considered finalized afterActor.initwas run. This also means that the same configuration used by theActoris set in the globalservice_locator.service_locatorbefore theActor.initservice_locatorand set it throughActor.(configuration=...)and runningActor.init()service_locatorand no configuration passed toActorwill create and set implicit default configurationApifyFileSystemStorageClientas local client to support pre-existing input file.ApifyStorageClientbased ontokenandapi_public_urland update NDU storage handling.Issues
Rated to: #513, #590
Testing