fix(samples): block zero patient samples - Ref gestion-de-projet#3117 #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2025 20:47
- Calculate expected patient count based on percentage and parent cohort size - Show error message when percentage would result in 0 patients - Disable create button until a valid percentage is entered Ref gestion-de-projet#3117
- Test error message when percentage results in 0 patients - Test create button is disabled for invalid samples - Test valid percentage allows sample creation Ref gestion-de-projet#3117
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #3117 by adding validation to prevent creating sample cohorts that would result in zero patients. When a user selects a percentage that would yield zero patients after rounding down (e.g., 1% of 3 patients = 0.03 → 0), the form now displays an error message and disables the create button.
Key changes:
- Added zero patient validation logic using Math.floor to calculate expected patient count
- Updated UI to show contextual error messages when percentage would result in zero patients
- Added comprehensive test coverage for the new validation feature
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/Researches/Modals/CreateSample.tsx | Implements zero patient validation by calculating expected patient count and adding error state that blocks sample creation when the result would be zero patients |
| src/components/Researches/Modals/tests/CreateSample.test.tsx | Adds comprehensive test suite covering various scenarios: error cases with small cohorts/percentages, success cases with valid combinations, and edge cases at boundaries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gfortaine
changed the title
gfortaine
force-pushed
the
fix/3117-block-zero-patient-samples
branch
from
d05f550 to
cf3a4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #[issue number] by @[issue author]
Description
Technical details
Tests