Merge pull request #69 from RongtongJin/ctypes_test

duhenglucky · web-flow · commit 5af73300eeba · 2019-11-04T22:28:07.000+08:00
chore(tests): polish tests
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -22,16 +22,23 @@
 
 @pytest.fixture(scope='session')
 def producer():
-    prod = Producer('testGroup', True)
+    prod = Producer('producer_group')
     prod.set_namesrv_addr('127.0.0.1:9876')
     prod.start()
     yield prod
     prod.shutdown()
 
+@pytest.fixture(scope='session')
+def orderly_producer():
+    prod = Producer('orderly_producer_group', True)
+    prod.set_namesrv_addr('127.0.0.1:9876')
+    prod.start()
+    yield prod
+    prod.shutdown()
 
 @pytest.fixture(scope='function')
 def push_consumer():
-    consumer = PushConsumer('testGroup')
+    consumer = PushConsumer('push_consumer_group')
     consumer.set_namesrv_addr('127.0.0.1:9876')
     yield consumer
     consumer.shutdown()
diff --git a/tests/test_consumer.py b/tests/test_consumer.py
@@ -21,7 +21,7 @@
 
 import pytest
 
-from rocketmq.client import Message, SendStatus, ConsumeStatus
+from rocketmq.client import Message, SendStatus, ConsumeStatus, PushConsumer
 from rocketmq.exceptions import PushConsumerStartFailed
 from rocketmq.consts import MessageProperty
 
@@ -35,9 +35,11 @@ def _send_test_msg(producer):
     assert ret.status == SendStatus.OK
 
 
-def test_push_consumer_no_subscription_start_fail(push_consumer):
+def test_push_consumer_no_subscription_start_fail():
+    consumer = PushConsumer('testGroup')
+    consumer.set_namesrv_addr("127.0.0.1:9876")
     with pytest.raises(PushConsumerStartFailed):
-        push_consumer.start()
+        consumer.start()
 
 
 def test_push_consumer(producer, push_consumer):
diff --git a/tests/test_producer.py b/tests/test_producer.py
@@ -42,12 +42,12 @@ def test_producer_send_oneway(producer):
     producer.send_oneway(msg)
 
 
-def test_producer_send_orderly_with_sharding_key(producer):
+def test_producer_send_orderly_with_sharding_key(orderly_producer):
     msg = Message('test')
     msg.set_keys('sharding_message')
     msg.set_tags('sharding')
     msg.set_body('sharding message')
-    ret = producer.send_orderly_with_sharding_key(msg, 'order1')
+    ret = orderly_producer.send_orderly_with_sharding_key(msg, 'order1')
     assert ret.status == SendStatus.OK
 
 
