fix: respect some values in values.yaml#785
Open
zyue110026 wants to merge 2 commits intoapache:masterfrom
Open
fix: respect some values in values.yaml#785zyue110026 wants to merge 2 commits intoapache:masterfrom
zyue110026 wants to merge 2 commits intoapache:masterfrom
Conversation
Signed-off-by: zyue110026 <[email protected]>
…rt, elasticsearch.service.loadBalancerIP, and elasticsearch.service.loadBalancerSourceRanges Signed-off-by: zyue110026 <[email protected]>
style95
reviewed
Aug 9, 2024
Member
style95
left a comment
style95
left a comment
There was a problem hiding this comment.
@zyue110026
Thank you for handling this.
| annotations: | ||
| service.alpha.kubernetes.io/tolerate-unready-endpoints: "true" | ||
| spec: | ||
| type: {{ .Values.elasticsearch.service.type }} |
Member
There was a problem hiding this comment.
Should this be the ClusterIP if no type is specified?
Contributor
Author
There was a problem hiding this comment.
Yes, ClusterIP is default service type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #784 respect grafana.imagePullPolicy, elasticsearch.service.type, elasticsearch.service.nodePort, elasticsearch.service.loadBalancerIP, and elasticsearch.service.loadBalancerSourceRanges